feat: new tools page that loads WM tools#504
Merged
lengyel-arpad85 merged 1 commit intomainfrom Mar 12, 2025
Merged
Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
huijing marked as non substantive for IPR from ash-nazg. |
huijing
approved these changes
Mar 12, 2025
Collaborator
huijing
left a comment
huijing
left a comment
There was a problem hiding this comment.
- Some of the buttons/fields have transparent background, can we standardise them to be white?
- The dropdown for choosing colour for background and text has a scrollbar but this problem only shows up on Chrome, specifically tested using Version 136.0.7063.0 (Official Build) canary (arm64)
All feedback is non-blocking, so approving this PR.
sidvishnoi
reviewed
Mar 12, 2025
|
|
||
| <style> | ||
| body { | ||
| background-image: url('/img/bg-tile.svg'); |
Collaborator
There was a problem hiding this comment.
Should either remove this background, or add a #ffffff on iframe, otherwise there's 2x web/mash background.
sidvishnoi
reviewed
Mar 12, 2025
|
|
||
| .iframe_content { | ||
| width: 100%; | ||
| height: calc(100vh - 190px); |
Collaborator
There was a problem hiding this comment.
Need to be careful with this on mobile.
DarianM
added a commit
to DarianM/webmonetization
that referenced
this pull request
May 29, 2025
This reverts commit a4a6db9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.